Skip to content

Add TLS verification and impersonation options to trino - #458

Open
Bohreromir wants to merge 1 commit into
worktree-unified-ca-certsfrom
feat/trino-connection-tls-impersonation
Open

Bohreromir wants to merge 1 commit into
worktree-unified-ca-certsfrom
feat/trino-connection-tls-impersonation

Conversation

@Bohreromir

@Bohreromir Bohreromir commented Nov 10, 2026 •

Copy link
Copy Markdown
Member

Description

Add TLS verification and impersonation options to user created trino connections

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

@Bohreromir
Bohreromir added this pull request to stack #459 November 10, 2026 20:29
@github-actions

github-actions Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 67.47% 9226 / 13674
🔵 Statements 66.43% 12410 / 18679
🔵 Functions 68.32% 2974 / 4353
🔵 Branches 57.4% 5196 / 9052
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/server/trino/client.ts 69.33% 66.66% 56.25% 75.75% 73, 74, 86-87, 107, 131-141, 155, 165, 227-228, 234, 270-277
src/lib/server/trino/config.ts 100% 100% 100% 100%
src/lib/server/trino/user-clients.ts 100% 100% 100% 100%
src/routes/(app)/trino/+page.server.ts 0% 0% 0% 0% 25-123
src/routes/(app)/trino/+page.svelte 0% 0% 0% 0% 409-847
src/routes/(app)/trino/validation.ts 33.33% 0% 0% 33.33% 8-29
Generated in workflow #1271 for commit 8596c50 by the Vitest Coverage Report Action

@Bohreromir Bohreromir self-assigned this Nov 10, 2026
@Bohreromir
Bohreromir marked this pull request as ready for review November 10, 2026 20:33
…nnection form

Connections entered on /trino could neither skip TLS certificate
verification nor turn off user impersonation.

- "Skip TLS certificate verification" toggle, only shown and accepted
  when STACKABLE_COCKPIT_TRINO_ALLOW_INSECURE_TLS=true
  (Helm: trino.tls.allowInsecureUserConnections)
- "Impersonate the logged-in user" toggle for basic auth, defaulting to
  STACKABLE_COCKPIT_TRINO_USER_IMPERSONATION
- Both settings are persisted in local storage; the connection summary
  shows "TLS unverified" when verification is skipped
@Bohreromir
Bohreromir force-pushed the feat/trino-connection-tls-impersonation branch from 5fff85b to 8596c50 Compare November 10, 2026 20:50
@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Nov 11, 2026
@labrenbe
labrenbe self-requested a review November 11, 2026 10:45
@labrenbe labrenbe moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

1 participant