Repository navigation
fix: Encode user ids and names as single URL path segments in UIF - #909
Merged
Merged
Conversation
The Keycloak and Entra backends joined request-supplied user ids and names onto the base URL as text, so `/`, `?`, `#` and `..` in them changed which URL was requested. Both now append them as one percent-encoded path segment through `append_path_segments`, and the Keycloak backend sends the username as a query parameter. An empty, `.` or `..` segment and one containing a line break are rejected with `400`, as the url crate would drop or strip them and look up a different user. A Keycloak `rootPath` without a trailing slash is now kept, which `Url::join` dropped.
maltesander
self-requested a review
October 29, 2026 13:32
maltesander
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
maltesander
previously approved these changes
Oct 29, 2026
maltesander
left a comment
maltesander
left a comment
Member
There was a problem hiding this comment.
Nice, LGTM!
--- PASS: kuttl (159.52s)
--- PASS: kuttl/harness (0.00s)
--- PASS: kuttl/harness/keycloak-user-info_opa-latest-1.20.2_keycloak-23.0.1_openshift-false (159.51s)
PASS
siegfriedweber
moved this from Development: In Review
to Development: Done
in Stackable Engineering
siegfriedweber
added
the
release-note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Builds the user-info-fetcher's Keycloak and Entra URLs with
UrlExt::join_safefrom operator-rs instead of interpolating request input into them.A user id or name is now encoded as exactly one URL path segment, and the Keycloak backend sends the username as a
usernamequery parameter rather than appending it to the URL as text. Previouslyalice&exact=falsecould switch off Keycloak's exact match, and../..could point the admin access token at a different endpoint. An id or name that cannot be a path segment (empty,.,.., or containing a line break) is rejected with400; the same failure for an id that the identity provider itself returned is reported as502, because it is a fault of the backend and not of the caller.As a side effect this also fixes a configured Keycloak
rootPathbeing dropped from every requested URL:endpoint_url()strips the trailing slash, andUrl::jointhen treated the last path component as a file name and replaced it, so a Keycloak served below e.g./authwas unreachable.join_safeonly ever appends segments, so the base path survives.Covered by unit tests per backend and by the
keycloak-user-infointegration test, which now serves Keycloak below/authso that a dropped root path fails the suite.Release Notes
Platform fixes
OPA operator
Definition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker