Skip to content

feat: add cockpit to release process - #133

Open
Bohreromir wants to merge 7 commits into
mainfrom
feat/add-cockpit-release
Open

Bohreromir wants to merge 7 commits into
mainfrom
feat/add-cockpit-release

Conversation

@Bohreromir

@Bohreromir Bohreromir commented Oct 30, 2026 •

Copy link
Copy Markdown
Member

Description

Adds the cockpit to our release process.

Caution

This won't work before stackabletech/cockpit#422 is merged

Docs

Release note

Checklist

Author

  • AI review done, findings addressed
  • Tests added or updated
  • Changelog updated (if the repo keeps one)

Reviewer

  • Useful comments and logging
  • Docs added or updated per the style guide

Acceptance

  • Check for release notes and docs

Comment thread release/post-release.sh Resolved
@Bohreromir Bohreromir changed the title feat: add cockpit feat: add cockpit to release process Oct 30, 2026
@Bohreromir
Bohreromir requested a review from Techassi October 30, 2026 15:52
@Bohreromir Bohreromir self-assigned this Oct 30, 2026
@Bohreromir Bohreromir moved this to Development: Waiting for Review in Stackable Engineering Oct 30, 2026
@Techassi Techassi moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Nov 2, 2026
Replace the cockpit-specific copies of check/update/tag functions with
the operator versions, extract a merge_repo helper in
merge-release-candidate.sh, make messages repo-neutral and fix the
cockpit README bullet.
@Bohreromir
Bohreromir marked this pull request as ready for review November 2, 2026 16:16
@Bohreromir Bohreromir mentioned this pull request Nov 4, 2026
1 of 6 tasks

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, just a few nits.

Comment thread release/common.sh Resolved
Comment thread release/post-release.sh Resolved
Comment thread release/post-release.sh Resolved
Comment thread release/post-release.sh Resolved
Comment thread release/tag-release-candidate.sh Resolved
Comment thread release/tag-release-candidate.sh Resolved

@Techassi Techassi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved from my side, but @NickLarsenNZ also wants to have another small look.

@NickLarsenNZ NickLarsenNZ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I tested jaq works in my nix shell and that the bat tests succeed.

@Bohreromir

Copy link
Copy Markdown
Member Author

Great, thank you! I'll wait for stackabletech/cockpit#422 to be merged before merging this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

3 participants