Repository navigation
refactor(changeprovider): Read Phabricator diffs through platform/conduit - #1014
Merged
Merged
Conversation
roychying
force-pushed
the
chenghan.ying/changeprovider-phab-conduit
branch
from
November 7, 2026 02:19
0b15719 to
0b516ed
Compare
mnoah1
approved these changes
Nov 13, 2026
roychying
force-pushed
the
chenghan.ying/changeprovider-phab-conduit
branch
from
November 14, 2026 04:32
0b516ed to
7621a1b
Compare
roychying
marked this pull request as ready for review
November 14, 2026 04:33
roychying
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
November 14, 2026 04:33
…duit, sending the token in the JSON params instead of an api.token query transport
…t to githubClient
…Hub and Phabricator callers share
roychying
force-pushed
the
chenghan.ying/changeprovider-phab-conduit
branch
from
November 14, 2026 04:56
7621a1b to
a5db8e9
Compare
roychying
enabled stacked auto-merge
November 14, 2026 04:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The Phabricator change provider hand-rolls its Conduit call: flat
ids[]=fields in the URL query, its own envelope type, Conduit errors as plain strings, and a token transport in the orchestrator wiring. Moving it ontoplatform/conduitmakes it the first consumer of the shared client.What?
Params.HTTPClientbecomesParams.Conduit *conduit.Client.differential.querydiffsis now oneCallwith{"ids": [...]}, and a diff missing from the result is still an error.error_codesurfaces as*conduit.Errorinstead of a formatted string; HTTP failures stayplatform/http.StatusError, so classification is unchanged.conduitClient, next togithubClient, and dropsapiTokenTransport.platform/README.mddescribes the protocol, endpoint and wiring layers that GitHub and Phabricator callers share.Test Plan
bazel test //submitqueue/extension/changeprovider/phabricator/... //service/submitqueue/orchestrator/server/...Issue