Repository navigation
fix(submitqueue): preserve conclude dead-letter outcomes - #1041
Draft
sbalabanov wants to merge 1 commit into
Draft
sbalabanov wants to merge 1 commit into
sbalabanov wants to merge 1 commit into
Conversation
sbalabanov
force-pushed
the
wt/sqc009
branch
from
November 13, 2026 21:16
c2484d1 to
d82799b
Compare
sbalabanov
force-pushed
the
wt/sqc014
branch
from
November 13, 2026 21:31
578951e to
02e9699
Compare
|
|
1 similar comment
|
|
sbalabanov
force-pushed
the
wt/sqc009
branch
2 times, most recently
from
November 14, 2026 01:54
73e67b9 to
81cd141
Compare
Summary: Reconcile a terminal batch's member requests and status logs when conclusion cannot finish. Preserve successful, failed, and cancelled outcomes, repair terminal membership, and retain incomplete payload obligations for retry. Test Plan: Existing tests cover all terminal outcome mappings, partial member log publication retries, different terminal winners, and final queue retention of incomplete work. Focused unit tests, affected library builds, formatting, lint, mock, module, and build metadata checks passed. Revert Plan: Pause conclude final processing before reverting. Preserve final queue records and request logs; do not reinterpret stored terminal outcomes as failures.
sbalabanov
force-pushed
the
wt/sqc014
branch
from
November 14, 2026 02:17
02e9699 to
2c221c8
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Conclusion retries finish request status updates without changing the recorded batch outcome.
Summary
A batch can finish while some of its requests still lack their final status updates. This change finishes those updates when conclusion retries, keeping successful work successful and preserving the original failed or cancelled result. If the batch is still running, records are missing, or the payload is invalid, keep the message for another attempt instead of guessing an outcome.
Repro
Succeededbatch containing two requests, then interruptconcludeafter one final status update succeeds and the next status-log write fails.conclude_dlq, then retry it after status-log writes work again.Landed, without turning successful work into an error.Test Plan
Failedbatch.Revert Plan
Pause conclude final processing before reverting. Retain final queue records
and request logs; do not reinterpret stored terminal outcomes as failures.
Issues