Skip to content

docs(consumer): explain rejection of invalid queue metadata - #1063

Merged
sbalabanov merged 1 commit into
mainfrom
wt/sqc010-envelope-retention
Nov 13, 2026
Merged

sbalabanov merged 1 commit into
mainfrom
wt/sqc010-envelope-retention

Conversation

@sbalabanov

@sbalabanov sbalabanov commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

TL;DR: Explain why bad queue information is logged and rejected, not retried.

Summary

This is a comment-only clarification of the existing policy: invalid queue information is logged and rejected, not retried. The same bad input will not repair itself, so any follow-up is an operator decision. With no later dead-letter queue, rejection may mark the delivery finished and discard it.

Repro

  1. Send a message whose queue fields disagree, such as Tenant=tenant-a and queue_name=tenant-b.
  2. Validation logs the error and rejects the message before the handler runs.
  3. With no later dead-letter queue, rejection may mark it finished without another attempt. This PR documents that existing outcome; it does not change or retry the message.

Test Plan

Checked with the existing tests:

  • Invalid queue information is rejected before the handler runs.
  • SQL rejection without a downstream dead-letter queue is still acknowledged; normal dead-letter handling is unchanged.
  • Existing validation tests and error logging are unchanged; the net code diff is only the explanatory comment.

Revert Plan

Remove the comment; existing message handling stays the same.

Issues

@sbalabanov sbalabanov changed the title fix(consumer): retain invalid final-queue envelopes docs(consumer): explain rejection of invalid queue metadata Nov 10, 2026
@sbalabanov
sbalabanov marked this pull request as ready for review November 10, 2026 21:43
@sbalabanov
sbalabanov requested review from a team and behinddwalls as code owners November 10, 2026 21:43
@cla-assistant

cla-assistant Bot commented Nov 13, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
@cla-assistant

cla-assistant Bot commented Nov 13, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Summary:
Document why invalid queue metadata is logged and rejected without retry.

Changes:
Explain permanent input errors and possible delivery drop without a later dead-letter queue.
Queue handling and diagnostics are unchanged.

Test Plan:
Existing consumer and SQL queue unit tests and consumer integration tests.
Formatting, lint, and dependency checks.

Revert Plan:
Remove the comment; existing queue handling remains unchanged.
@sbalabanov
sbalabanov force-pushed the wt/sqc010-envelope-retention branch from 94f949f to 83a7174 Compare November 13, 2026 20:48
@sbalabanov
sbalabanov merged commit 6d887cd into main Nov 13, 2026
20 of 21 checks passed
@sbalabanov
sbalabanov deleted the wt/sqc010-envelope-retention branch November 13, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants