Repository navigation
docs: make terminal-only DLQ policy explicit - #1075
Merged
Merged
Conversation
|
|
sbalabanov
commented
Nov 12, 2026
sbalabanov
marked this pull request as ready for review
November 12, 2026 21:47
prathshenoy
approved these changes
Nov 12, 2026
Summary: Keep final DLQ retries focused on terminal reconciliation, not restarting failed workflows. Intent: Conflicting retry and partial-transition guidance could lead an implementer to reuse an idempotent Start controller on a DLQ, creating Started and publishing validation again. Make that boundary explicit without changing runtime behavior. Changes: - Add the terminal-only rule and explicit maintainer-approval requirement to Design Defaults. - Correct the existing DLQ guide and link workflow wiring to its source, preserving the named narrow exceptions. - Narrow Stovepipe request-log repair wording to terminal/history obligations. Test Plan: Checked wording against current stage bindings and terminal handlers; all 30 local Markdown links resolve and git diff --check passes. make gazelle completed without BUILD changes. No runtime tests were run for this documentation-only change. Revert Plan: Revert this documentation commit.
Summary: Keep terminal-only DLQ reconciliation as the default while requiring an explicit user request or owning-maintainer approval for recovery exceptions. Changes: - Restore the simplest-and-most-reliable implementation principle. - Remove the requested top-level retry and implementer-authored authorization sentences. - Clarify that agents must not choose recovery exceptions on their own. Test Plan: Read both complete review threads and checked the requested wording changes. git diff --check passes and all 17 local Markdown links in the two changed files resolve. make gazelle completed without BUILD changes. No runtime tests were run for this documentation-only change. Revert Plan: Revert this documentation commit.
sbalabanov
force-pushed
the
wt/dlq-policy-docs
branch
from
November 14, 2026 01:17
a4c10e6 to
200916a
Compare
Summary: Describe downstream batch-ownership preservation on the generic request DLQ path without implying that every DLQ handler uses its guard. Test Plan: Statically traced the generic request and conflict-signal DLQ paths through their terminal helper. Verified the changed paragraph retains the no-restart and terminal-winner statements and both links resolve; git diff --check passes. make gazelle produced no BUILD changes. No runtime tests were run for this documentation-only correction. Revert Plan: Revert this documentation commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep final DLQ retries focused on terminal reconciliation, not restarting failed workflows.
Summary
An already-failed batch can still have unfinished member-status fan-out. The documented DLQ boundary allows repairing those terminal outputs without restarting validation, builds, or merges.
Documentation only; no queue bindings or runtime behavior change.
Test Plan
Checked the wording against the current stage bindings and terminal handlers, including owner/winner preservation, terminal fan-out, speculation's other-work nudge, hook disposition, and Stovepipe record notifications. All 30 local Markdown links in the four changed documents resolve, and
git diff --checkpasses.make gazellecompleted without BUILD changes. No runtime tests were run locally for this documentation-only change.Revert Plan
Revert this PR.