Repository navigation
Conversation
Summary: - Let hooks return a result with an optional Unix millisecond retry deadline so integrations can honor cooldowns without keeping a worker busy. - Reuse Delivery.Hold after concurrent dispatch, choosing the latest requested deadline while preserving normal handling for every actual failure. - Update the no-op hook, generated mock, contract documentation, and dispatcher regression coverage. Test Plan: - Bazel hook and no-op suites cover completed, deferred, expired, concurrent, and mixed failure outcomes. - Stovepipe, SubmitQueue orchestrator, and Runway reference servers build with the new signature. - make lint, make check-tidy, and make check-gazelle pass. Run ./tool/bazel test //platform/hook:go_default_test //platform/extension/hook/noop:go_default_test to reproduce the focused tests. API Changes: Hook.Handle now returns (hook.Result, error). Consumers return a zero result when done; a positive RetryNotBeforeMs requests deferred redelivery. Any hook error takes precedence over all deferral results. Revert Plan: Revert this PR and migrate callers back to the previous Handle signature together.
mnoah1
marked this pull request as ready for review
November 13, 2026 21:25
mnoah1
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
November 13, 2026 21:25
mnoah1
marked this pull request as draft
November 13, 2026 21:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Revert Plan
Revert this PR and migrate callers back to the previous Handle signature together.
API Changes
Hook.Handle now returns (hook.Result, error). Consumers return a zero result when done; a positive RetryNotBeforeMs requests deferred redelivery. Any hook error takes precedence over all deferral results.
Issue Links
None — public API enhancement without a public tracking issue.