Repository navigation
fix(stovepipe): persist the terminal outcome reason on Request - #965
Open
sbalabanov wants to merge 1 commit into
Open
sbalabanov wants to merge 1 commit into
sbalabanov wants to merge 1 commit into
Conversation
sbalabanov
marked this pull request as ready for review
October 27, 2026 23:41
sbalabanov
marked this pull request as draft
October 29, 2026 16:24
sbalabanov
marked this pull request as ready for review
October 29, 2026 22:37
sbalabanov
force-pushed
the
sergeyb/sp-oct-001-terminal-reason
branch
from
November 6, 2026 20:35
d42b7fd to
92b3604
Compare
A DLQ can save a failed request before its first outcome log is retained. A late build poll then infers build_failed from the state alone, losing the polling or stage failure that actually ended the request. Store the typed outcome reason in the same terminal compare-and-swap as the state and reuse it when constructing state logs. Keep the existing retained-log replay and terminal-build safeguards; legacy snapshots fall back to the writer's reason. Add the MySQL column before deploying.
sbalabanov
force-pushed
the
sergeyb/sp-oct-001-terminal-reason
branch
from
November 14, 2026 01:48
92b3604 to
fdecb29
Compare
|
|
1 similar comment
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: Keep the original failure reason when request handling retries.
Why?
A request can be saved as failed before its first status log is written. A later build poll sees only "failed" and can report a build failure even when polling or another stage actually failed.
Repro:
build_failedinstead ofbuild_polling_exhausted.What?
Save the typed reason together with the terminal request state, then reuse it for status logs. Requests without a saved reason keep the existing fallback; existing logs are not changed.
Rollout
Existing MySQL deployments must add
outcome_reason VARCHAR(64) NOT NULL DEFAULT ''torequestbefore deploying these readers and writers. This PR does not apply or schedule the migration.Test Plan
Revert Plan
Revert the code; leave the additive column in place until all newer processes have stopped using it.
Issue Links
None — standalone failure-reason consistency fix.