Repository navigation
Unified: Populate external_name_node for enum case parameters - #23096
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the update to preserve Swift enum case parameter labels.
No open issues 🎉
What changed in this PR
This PR updates the unified Swift extractor to populate external_name_node for enum case parameters, preserving their labels in the extracted representation.
Changes:
- Add
external_name_nodealongside the existing parameter pattern and type. - Update expected corpus output to include the
radiusandsidelabels.
| File | Description |
|---|---|
unified/extractor/tests/corpus/swift/types/enum-with-associated-values.output |
Update expected output for labeled enum case parameters. |
unified/extractor/src/languages/swift/swift.rs |
Populate external-name nodes when translating enum case parameters. |
Review effort: Balanced (auto)
asgerf
approved these changes
Nov 11, 2026
asgerf
left a comment
asgerf
left a comment
Contributor
There was a problem hiding this comment.
LGTM. There is the caveat that the argument label is optional when calling an enum constructor but this is probably still the most sensible thing to extract.
Contributor
|
Sorry, the argument label is optional in constructor patterns, not at call sites. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.