Skip to content

Unified: Populate external_name_node for enum case parameters #23096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hvitved merged 1 commit into from
Nov 11, 2026
+8 −3
Merged

Unified: Populate external_name_node for enum case parameters #23096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion unified/extractor/src/languages/swift/swift.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,7 +518,10 @@ fn translation_rules() -> Vec<Rule<SwiftContext>> {
rule!(
(enumCaseParameter firstName: _? @@name type: @ty)
=>
(parameter pattern: [(identifier #{name})] type: {ty})
(parameter
external_name_node: [(identifier #{name})]
pattern: [(identifier #{name})]
type: {ty})
),
// An enum element with associated values (`case circle(radius: Double)`)
// becomes a nested `class_like_declaration` whose constructor carries the
Expand Down
6 changes: 4 additions & 2 deletions unified/extractor/tests/corpus/swift/types/enum-with-associated-values.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@ top_level source="⟨body⟩"
member:
constructor_declaration source="circle(⟨parameter⟩)"
parameter:
parameter source="⟨pattern⟩: ⟨type⟩"
parameter source="⟨external_name_node⟩⟨pattern⟩: ⟨type⟩"
external_name_node: identifier "radius" source="radius"
type: identifier "Double" source="Double"
pattern: identifier "radius" source="radius"
body: block source=""
Expand All @@ -89,7 +90,8 @@ top_level source="⟨body⟩"
member:
constructor_declaration source="square(⟨parameter⟩)"
parameter:
parameter source="⟨pattern⟩: ⟨type⟩"
parameter source="⟨external_name_node⟩⟨pattern⟩: ⟨type⟩"
external_name_node: identifier "side" source="side"
type: identifier "Double" source="Double"
pattern: identifier "side" source="side"
body: block source=""
Loading